fix(state): Propagate schema reconciliation failures - #82568
Open
thanosapollo wants to merge 1 commit into
Open
thanosapollo wants to merge 1 commit into
thanosapollo wants to merge 1 commit into
Conversation
Only a concurrent duplicate-column race is benign. Let schema inspection, lock, busy, and other migration failures reach SessionDB's existing open retry and error path instead of reporting a half-reconciled schema as initialized. Fixes NousResearch#79531
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops schema reconciliation from silently swallowing SQLite lock and migration errors. Only the benign concurrent
duplicate column namerace is ignored, allowingSessionDB's existing open retry path to handle transient contention.Related Issue
Fixes #79531
This complements #80797: that PR fixes stale-schema detection on read-only opens; this PR fixes the independent writable-reconciliation path that swallowed migration lock and other operational errors. #80030 was an earlier draft of the #80797 approach.
Type of Change
Changes Made
ALTER TABLEfailures.ALTER TABLElocks, and duplicate-column races.How to Test
Results: 14 passed; 3 passed. Ruff and Python compile checks pass.
Checklist