fix(webhook): retry failed direct deliveries - #82508
Open
alexgunsberg wants to merge 1 commit into
Open
Conversation
Collaborator
alexgunsberg
force-pushed
the
fix/webhook-delivery-idempotency
branch
from
August 9, 2026 15:30
91d0a3c to
1fac89f
Compare
alexgunsberg
force-pushed
the
fix/webhook-delivery-idempotency
branch
from
August 9, 2026 15:37
1fac89f to
a0dc9d7
Compare
Author
|
Independent exact-head review: PASS at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deliver_onlywebhook IDs in a separate in-flight set so concurrent duplicates still send once even when a downstream send outlives the normal TTLRegression coverage
SendResultthen same-ID retry succeedsVerification
pytest tests/gateway/test_webhook_deliver_only.py -o addopts= -q— 9 passedpytest tests/gateway/test_webhook_*.py -o addopts= -q— 54 passedpy_compile, andgit diff --check— passedPrior art and scope
Related to #47293 by @necoweb3. That older branch currently conflicts with
mainand also changes agent-mode completion semantics; this current-main patch preserves credit here while staying narrowly scoped to thedeliver_onlytransaction required by the production watcher.No live gateway, config, secret, webhook subscription, or deploy state was modified. Do not merge before the independent exact-head review of
a0dc9d76bc6c4e3beb865e999ae82d109d06fa08passes.