Conversation
129b464 to
f0fe219
Compare
Unblock request: first-time fork workflow approval
Required check from
GitHub Actions never started jobs for this head. Current runs are stuck at
This is the first-time external contributor workflow approval gate. A maintainer needs to approve the pending workflow runs for this fork PR so CI can execute. Local verification already completed on current
Please approve workflows for this PR when convenient. I cannot self-approve them with fork permissions. |
Maintainer note (companion to #83278)This remains the focused test-isolation PR only. Already labeled by triage:
Local verification:
Still blocked only by first-time fork workflow approval (no jobs started):
Please approve workflows when convenient. Related auth fix is #83278 (carries forward @alt-glitch triage from superseded #80581). |
What does this PR do?
Makes the affected test fixtures independent of credentials and source trees present on the host machine.
sys.pathinsertion that could import a stale~/.hermes/hermes-agentcheckout instead of the checkout under test.This fixes machine-dependent failures without changing runtime credential behavior.
Related Issue
No existing issue found. This updates the previously opened fixture-isolation PR on a current
mainbase.Type of Change
Changes Made
tests/agent/test_anthropic_output_field_leak.py: remove the host-specific import-path override.tests/agent/test_credential_pool_routing.py: isolate the fixture from host auth discovery and assert the exact credential-pool contents.How to Test
21 passed.No Windows footguns found (2 file(s) scanned).origin/mainreproduced 20 failing tests across 10 files and a 300-second timeout intests/cli/test_worktree.py. Reproduced upstream failures include Hindsight provider, readiness, systemd socket, worktree, approval, computer-use, file-tools, execution-flag, and voice-mode tests.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass. Blocked by pre-existing upstream failures documented above.Documentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Focused test result:
The full-suite blocker is documented above with a matching
origin/mainreproduction.