fix: add explicit encoding="utf-8" to YAML/config open() calls - #8248
Closed
Aliciawque wants to merge 1 commit into
Closed
fix: add explicit encoding="utf-8" to YAML/config open() calls#8248Aliciawque wants to merge 1 commit into
Aliciawque wants to merge 1 commit into
Conversation
On Windows, Python's open() defaults to the system locale encoding (often cp1252), not UTF-8. Config files containing non-ASCII content (CJK model names, non-ASCII paths, plugin descriptions) would raise UnicodeDecodeError or silently produce mojibake. 12 call sites across 8 files -- all reading or writing config.yaml, plugin manifests, or model metadata cache -- now specify encoding="utf-8" explicitly, matching the pattern already used elsewhere in the codebase (e.g. prompt_builder.py, hermes_state.py, all Path.read_text() calls). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alt-glitch
added
type/bug
Collaborator
Author
|
Thanks for the triage. Agreed, #15519 covers this more broadly, so I’ll close this one in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.