Skip to content

fix: drop empty tool_calls arrays on assistant messages (strict providers 400) #82252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prateekranka wants to merge 1 commit into from
+30 −1
Closed

fix: drop empty tool_calls arrays on assistant messages (strict providers 400) #82252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion agent/agent_runtime_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3458,7 +3458,14 @@ def sanitize_api_messages(messages: List[Dict[str, Any]]) -> List[Dict[str, Any]
seen_assistant_call_ids.add(cid)
kept_tcs.append(tc)
if len(kept_tcs) != len(msg.get("tool_calls") or []):
msg = {**msg, "tool_calls": kept_tcs}
if kept_tcs:
msg = {**msg, "tool_calls": kept_tcs}
else:
# All calls were duplicate ids — drop the key entirely.
# Setting tool_calls: [] makes strict providers (DeepSeek)
# 400 with "empty array" even though the early sanitizer
# pass already ran.
msg = {k: v for k, v in msg.items() if k != "tool_calls"}
deduped.append(msg)
elif role == "tool":
cid = (msg.get("tool_call_id") or "").strip()
Expand All @@ -3476,6 +3483,28 @@ def sanitize_api_messages(messages: List[Dict[str, Any]]) -> List[Dict[str, Any]
"Pre-call sanitizer: removed %d duplicate tool_call_id reference(s)",
removed_dupes,
)

# Final pass: dedup can leave assistant messages with tool_calls: [] when
# every call in a turn was a duplicate id. Strict providers reject that.
final: List[Dict[str, Any]] = []
dropped_empty_after_dedup = 0
for msg in messages:
if (
isinstance(msg, dict)
and msg.get("role") == "assistant"
and "tool_calls" in msg
and not (isinstance(msg["tool_calls"], list) and msg["tool_calls"])
):
msg = {k: v for k, v in msg.items() if k != "tool_calls"}
dropped_empty_after_dedup += 1
final.append(msg)
if dropped_empty_after_dedup:
_ra().logger.debug(
"Pre-call sanitizer: dropped empty tool_calls on %d assistant "
"message(s) after dedup",
dropped_empty_after_dedup,
)
messages = final
return messages


Expand Down