fix(tests): make test_doctor_journal_modes collectable and green on Windows

[hyqqx]

What does this PR do?

tests/hermes_cli/test_doctor_journal_modes.py is new in v0.20.0 (658329708) and aborts collection on native Windows. pytest stops the entire run on a collection error, so no test in the invocation gets to execute:

ERROR collecting tests/hermes_cli/test_doctor_journal_modes.py
E   AttributeError: module 'os' has no attribute 'geteuid'

The Windows guard is already there — it just never runs

@pytest.mark.skipif(os.name == "nt", reason="chmod is a no-op on Windows")
@pytest.mark.skipif(os.geteuid() == 0, reason="root ignores file permissions")
def test_read_only_directory_is_still_readable(self, tmp_path):

The first decorator is correct and does exactly the right thing. The second one evaluates os.geteuid() at import time, before pytest looks at either marker — and os.geteuid does not exist on Windows. The author's own guard is annulled by the line directly beneath it.

Short-circuiting on hasattr fixes it, and it is the form already used for this same pair in tests/test_hermes_state_readonly_preflight.py:31:

@pytest.mark.skipif(
    hasattr(os, "geteuid") and os.geteuid() == 0,
    reason="root ignores file permissions",
)

POSIX behaviour is byte-identical — hasattr(os, "geteuid") is True there, so the euid check runs exactly as before.

One more failure becomes reachable once collection is unblocked

test_lists_every_managed_database asserts a POSIX path:

assert "kanban/boards/myboard/kanban.db is in WAL mode" in out

doctor names nested databases with str(board_db.relative_to(hermes_home)) (hermes_cli/doctor.py:114), which uses the platform separator — so on Windows the output carries backslashes. The product is correct on both platforms; only the expectation was POSIX-only. It is now built with os.path.join so it follows whatever separator the host uses.

No production code is touched.

How to test

On native Windows, from PowerShell:

python -m pytest tests/hermes_cli/test_doctor_journal_modes.py -q -rs

Before:

ERROR collecting tests/hermes_cli/test_doctor_journal_modes.py
E   AttributeError: module 'os' has no attribute 'geteuid'
Interrupted: 1 error during collection

After:

25 passed, 2 skipped in 1.95s

SKIPPED [1] test_doctor_journal_modes.py:116: chmod is a no-op on Windows
SKIPPED [1] test_doctor_journal_modes.py:218: chmod is a no-op on Windows

The two skips carry the author's own reason — now actually firing.

On Linux/macOS nothing changes: both markers evaluate as before and all 27 tests run.

Scope

I collected all 230 test files added since v2026.7.30 on this host. This was the only collection error among them, and the bare skipif(os.geteuid()...) pattern appears nowhere else under tests/.

Why CI never caught this

All CI jobs run on ubuntu-latest (the only other runner in the tree is ubuntu-24.04-arm in docker.yml). There is no Windows runner, so os.geteuid always exists in CI and the import-time evaluation never raises.

Platforms tested

Native Windows 11 Home, build 26200 · Python 3.11.6 · PowerShell.

Related

• 658329708 — feat(doctor): report per-database journal mode with WAL-reset exposure, which added the file two days ago.
• test: make Windows test suite work - skip POSIX-only tests, add platform helpers #74300 — open PR doing Windows skip-marker work across the suite; it does not touch this file (it predates it).

[monerostar]

Native Win11 verification (monerostar)

Host: Windows 11 (build 10.0.26200), Python 3.11.15, pytest 9.1.1
SHA reviewed: c8c3ae8cd

Baseline (upstream/main @ 222465d84)

python -m pytest tests/hermes_cli/test_doctor_journal_modes.py -o addopts= --collect-only
# ERROR collecting tests/hermes_cli/test_doctor_journal_modes.py
# E   AttributeError: module 'os' has no attribute 'geteuid'
# (decorator line: @pytest.mark.skipif(os.geteuid() == 0, ...))

Bare os.geteuid() is evaluated at import/class-body time, so the existing os.name == "nt" skip never gets a chance to run. Confirmed live: hasattr(os, "geteuid") is False on this host.

This PR

python -m pytest tests/hermes_cli/test_doctor_journal_modes.py -o addopts=
# 27 collected → 25 passed, 2 skipped in ~2.3s

Both chmod-gated tests correctly skip on nt. test_lists_every_managed_database passes with the os.path.join(...) expectation (backslash path on Windows).

Verdict

Matches the stated bug class and the existing hasattr(os, "geteuid") pattern elsewhere. Test-only, focused, green on native Win11. LGTM from a Windows contributor host.

[monerostar]

Sibling note (Win11 verify pass tonight): #84073 covers the same geteuid collection abort plus the test_run_tests_parallel.py /tmp → tempfile.gettempdir() handoff (issue #83935). #74083 is handoff-only. Maintainers can land any one complete path; no need for all three.