Skip to content

fix(feishu): drop root_id fallback for thread_id in DM replies - #81496

Open
GodJones wants to merge 1 commit into
NousResearch:mainfrom
GodJones:feishu-rootid-fix-jonesxr
Open

GodJones wants to merge 1 commit into
NousResearch:mainfrom
GodJones:feishu-rootid-fix-jonesxr

Conversation

@GodJones

@GodJones GodJones commented Aug 8, 2026

Copy link
Copy Markdown

Summary

  • Feishu adapter was falling back to root_id when resolving thread_id for inbound DM replies. Feishu sets root_id on ordinary inline DM replies, which caused them to spawn a new thread-keyed session instead of staying in the main chat session.
  • Now thread_id only uses the explicit thread_id (forum topics); root_id fallback removed. reply_to_message_id still retains root_id as an intentional reply anchor (distinct concern).

Test plan

  • Inbound Feishu DM reply no longer creates a new thread-keyed session.
  • Forum-topic thread_id routing still works.
  • Replies to a specific message still anchor via reply_to_message_id.

🤖 Generated with Hermes Agent

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins platform/feishu Feishu / Lark adapter sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Aug 8, 2026
Feishu sets root_id on ordinary inline replies, which must stay in the
main chat session. Using it as thread_id spawned a new thread-keyed
session and bound replies to the quoted message.

Refs: NousResearch#29466 (open), PR NousResearch#29467 (closed, unmerged). Local-only fix on a
branch so it survives updates via rebase origin/main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have platform/feishu Feishu / Lark adapter sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants