Skip to content

[DEPRECATED] superseded by #81165 - #81099

Closed
echoes666 wants to merge 1 commit into
NousResearch:mainfrom
echoes666:fix/profile-switch-secondary-routing
Closed

[DEPRECATED] superseded by #81165#81099
echoes666 wants to merge 1 commit into
NousResearch:mainfrom
echoes666:fix/profile-switch-secondary-routing

Conversation

@echoes666

@echoes666 echoes666 commented Aug 7, 2026

Copy link
Copy Markdown

This PR is deprecated. Superseded by #81165 (same fix, rebased onto current main). The branch was force-pushed during a botched local amend, which destroyed the tree. The diff on this page is a broken snapshot of that mistake - please ignore it and review #81165 instead. Issue: #81094

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/desktop Electron desktop app (apps/desktop/*) area/profiles Multi-profile isolation, HERMES_HOME scoping sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages labels Aug 7, 2026
… to primary socket

When switching to a secondary profile, openSecondary/ensureGatewayForProfile
could silently fall back to the primary socket if the target backend's
WebSocket failed to open (e.g. a manually started gateway process holding
the profile's resources). This routed the user's messages to the wrong
profile's backend and caused cross-profile session writes.

- openSecondary: rethrow connect failures with an actionable message
- ensureGatewayForProfile: log and rethrow switch failures instead of
  swallowing them (no silent primary fallback)

Closes NousResearch#81094
@echoes666 echoes666 closed this Aug 7, 2026
@echoes666
echoes666 force-pushed the fix/profile-switch-secondary-routing branch from 6a132cf to ace68bb Compare August 7, 2026 15:02
@echoes666 echoes666 changed the title fix(desktop): surface profile-switch failures instead of falling back to primary socket [DEPRECATED] superseded by #81165 Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/profiles Multi-profile isolation, HERMES_HOME scoping comp/desktop Electron desktop app (apps/desktop/*) P2 Medium — degraded but workaround exists sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants