fix(desktop): keep tab strip when preview/Browser is open - #80958
Closed
HexLab98 wants to merge 2 commits into
Closed
fix(desktop): keep tab strip when preview/Browser is open#80958HexLab98 wants to merge 2 commits into
HexLab98 wants to merge 2 commits into
Conversation
Sticky "Hide tab bar" was winning over closeable main tiles, so an in-app Browser/preview could open with no strip and no close control.
Lock the trap where headerHidden:true must not hide the strip while a closeable preview/Browser tile is shown, while tool-only sticky hide stays.
14 tasks
5 tasks
Collaborator
|
Your #91714 arrives at the same design and generalizes it: one resolver both the renderer and the store call, with the hidden flag itself replaced by a tri-state mode so a repair can no longer overwrite a preference. Credited in the description. Closing in favor of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npx vitest run src/components/pane-shell/tree/renderer/lone-header.test.ts src/components/pane-shell/tree/tool-pane-toggle.test.ts(fromapps/desktop)