Skip to content

fix(desktop): keep tab strip when preview/Browser is open - #80958

Closed
HexLab98 wants to merge 2 commits into
NousResearch:mainfrom
HexLab98:fix/desktop-preview-hidden-header-trap
Closed

fix(desktop): keep tab strip when preview/Browser is open#80958
HexLab98 wants to merge 2 commits into
NousResearch:mainfrom
HexLab98:fix/desktop-preview-hidden-header-trap

Conversation

@HexLab98

@HexLab98 HexLab98 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Sticky "Hide tab bar" could leave an in-app Browser/preview open with no tab strip and no close control.
  • Closeable main tiles (preview / Browser / session) now keep the strip visible so the close affordance stays available.
  • Tool-only zones still honor a deliberate sticky hide.

Test plan

  • npx vitest run src/components/pane-shell/tree/renderer/lone-header.test.ts src/components/pane-shell/tree/tool-pane-toggle.test.ts (from apps/desktop)
  • In Hermes Desktop: open an HTML/URL preview, hide the tab bar (or double-tap the strip), confirm the strip/close control returns while the preview is open
  • Hide the tab bar on a tools-only zone (terminal/logs), close and re-open a tool pane, confirm sticky hide still sticks
  • Lone chat workspace still auto-hides the strip when no preview/session tile is open

Sticky "Hide tab bar" was winning over closeable main tiles, so an in-app
Browser/preview could open with no strip and no close control.
Lock the trap where headerHidden:true must not hide the strip while a
closeable preview/Browser tile is shown, while tool-only sticky hide stays.
@OutThisLife

Copy link
Copy Markdown
Collaborator

Your resolveZoneHeaderHidden is the right shape — a closeable main tile has to outrank the hidden flag, and pulling the precedence into one function is what the inline expression in TreeGroup was missing.

#91714 arrives at the same design and generalizes it: one resolver both the renderer and the store call, with the hidden flag itself replaced by a tri-state mode so a repair can no longer overwrite a preference. Credited in the description. Closing in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants