Repository navigation
fix(skills): require --force to replace an untracked skill on install #80903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
briandevans
wants to merge
3
commits into
NousResearch:main
Choose a base branch
from
briandevans:fix/skills-install-unlocked-local-overwrite-80848
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
4af76f4
fix(skills): require --force to replace an untracked skill on install
briandevans faec6d6
fix(skills): name the resolved deletion target in the untracked-skill…
briandevans 0398a15
fix(skills): report the untracked-skill refusal on the tui_gateway su…
briandevans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and fixed in
faec6d69a93(current head).You're right that the two can diverge, and it's worth spelling out how far:
_untracked_skill_dir()routes the category through_validate_install_parent_path()→_normalize_bundle_path(), which drops empty and.segments and rewrites\→/, then_resolve_lock_install_path().resolve()s the result. So--category "personal//./notes"produced a prompt namingskills/personal//./notes/note-takerwhile the directoryinstall_from_quarantine()would havermtree'd wasskills/personal/notes/note-taker. Naming the deletion target is the entire purpose of this prompt, so a mismatch defeats it.The message is now derived from the resolved
untrackedpath (hermes_cli/skills_hub.py:685-692), keeping the profile-safedisplay_hermes_home()shorthand and falling back to the absolute path when the target lies outsideHERMES_HOME(i.e. aSKILLS_DIRoverride, where there is no~/shorthand to apply).Pinned by
test_untracked_warning_names_the_resolved_deletion_targetintests/hermes_cli/test_skills_hub.py:369. It asserts the emitted path equals_untracked_skill_dir()'s return value — the actualrmtreetarget — and that the raw category string is absent from the output. Verified red before the change (the assertion diff showed the two paths side by side) and green after; the file's 7 tests pass.One deliberate exclusion: the same raw-
categoryconstruct appears in the two "Files will be at:" panels further down (the Official Skill and Disclaimer panels). Those describe an install destination rather than a deletion target, and they are not part of this PR's diff, so I've left them alone rather than widen an in-review change. Happy to send a follow-up for them if you'd like the normalization applied there too.