fix(gateway): guard Teams multiplex listener ownership - #80825
Closed
JoelMTaylor wants to merge 1 commit into
Closed
fix(gateway): guard Teams multiplex listener ownership#80825JoelMTaylor wants to merge 1 commit into
JoelMTaylor wants to merge 1 commit into
Conversation
teknium1
added a commit
that referenced
this pull request
Sep 2, 2026
teknium1
added a commit
that referenced
this pull request
Sep 2, 2026
teknium1
added a commit
that referenced
this pull request
Sep 2, 2026
teknium1
added a commit
that referenced
this pull request
Sep 2, 2026
teknium1
added a commit
that referenced
this pull request
Sep 2, 2026
teknium1
added a commit
that referenced
this pull request
Sep 2, 2026
teknium1
added a commit
that referenced
this pull request
Sep 2, 2026
Contributor
|
Thanks @JoelMTaylor — Merged via #101252 (2e25b47) on current main. Your commits from this PR were cherry-picked onto the salvage branch with your git authorship preserved, so the credit is yours in Closing this PR since the work is now on main. |
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Teams adapter always starts an HTTP listener on its configured port (3978 by default), but Teams was missing from the shared port-binding registry. In multiplex mode, secondary profiles could therefore attempt to start additional Teams listeners on the same host port, producing address-in-use failures and unreliable inbound delivery.
The default profile should own the shared listener and route profile-specific traffic through the existing multiplex URL prefixes.
Impact
Misconfigured secondary Teams profiles are skipped with an actionable warning instead of attempting a conflicting socket bind. Single-profile Teams gateways are unchanged.
Validation
scripts/run_tests.sh tests/gateway/test_multiplex_adapter_registry.py --file-timeout 60 -- -qResult: 16 passed.