Skip to content

Add docker configuration options to file_tools.py - #80744

Open
tanjelly wants to merge 1 commit into
NousResearch:mainfrom
tanjelly:patch-2
Open

Add docker configuration options to file_tools.py#80744
tanjelly wants to merge 1 commit into
NousResearch:mainfrom
tanjelly:patch-2

Conversation

@tanjelly

@tanjelly tanjelly commented Aug 7, 2026

Copy link
Copy Markdown

What does this PR do?

这三个字段正是平台对 Hermes 沙箱做定制化管控的关键开关:

参数 控制什么 不补丁的后果
docker_env 容器内环境变量键值对 无法向沙箱注入固定环境变量
docker_extra_args docker run 的任意额外参数 无法对沙箱做细粒度 Docker 级控制
docker_persist_across_processes 容器是否跨调用复用 容器生命周期策略不可配置

Related Issue

None

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/tools Tool registry, model_tools, toolsets tool/file File tools (read, write, patch, search) backend/docker Docker container execution area/config Config system, migrations, profiles sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Aug 7, 2026
@spfcraze

spfcraze commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

This was generated by AI during triage.

Summary:
Open PR #65367 already changes tools/file_tools.py for the same purpose — propagating docker config to file tools — so this PR overlaps in-flight work.

Problems:

Solution:
Consolidate with #65367, which predates this PR and targets the same file, so both changes do not land on the same lines.


Checked against e6a8b09 — the tip of patch-2 when this was written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles backend/docker Docker container execution comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/file File tools (read, write, patch, search) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants