Skip to content

fix(gateway): preserve archived compaction history on /retry rewrite (#80216) #80695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RelaxJonh wants to merge 1 commit into from
Closed

fix(gateway): preserve archived compaction history on /retry rewrite (#80216) #80695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion gateway/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3379,7 +3379,13 @@ def rewrite_transcript(self, session_id: str, messages: List[Dict[str, Any]]) ->
return True
self._clear_dirty_transcript(session_id)
try:
self._db.replace_messages(session_id, messages)
# When the session has soft-archived rows (e.g. in-place compaction
# history), restrict the DELETE to active-only rows so the archived
# turns survive the rewrite. Without this guard, /retry (and any
# other caller of rewrite_transcript) silently destroys the
# durable pre-compaction history (#80216).
active_only = self._db.has_archived_messages(session_id)
self._db.replace_messages(session_id, messages, active_only=active_only)
return True
except Exception as e:
logger.debug("Failed to rewrite transcript in DB: %s", e)
Expand Down
Loading