refactor(auth): extract TLS verification helpers (S3) - #80676
Open
andrexibiza wants to merge 1 commit into
Open
Conversation
Signed-off-by: andrexibiza <84248988+andrexibiza@users.noreply.github.com>
This was referenced Aug 7, 2026
Contributor
refactor(auth): extract TLS verification helpers (S3)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Extract the S3 TLS verification helpers from
hermes_cli/auth.pyintohermes_cli/auth_tls_verify.py.auth.py:5069–5125._default_verifyand_resolve_verify(5073–5123).hermes_cli.authcompatibility seam.certifilazy.This is one independently reviewable slice of the auth.py god-file . It does not claim the full auth.py decomposition is complete.
Verification
Base:
origin/main0957277f2f468bac22bbfcfa7c43029858c9597e.delattr/NameErrorbehavior, py_compile, reverse-apply, and diff hygiene.51b382430b25dc0eb88e6f7e3f535d68c2ffd07e.git diff --check: clean.py_compile: both changed modules pass.hermes_cli/auth.py,hermes_cli/auth_tls_verify.py.The two proven baseline-only failures are:
tests/hermes_cli/test_auth_nous_provider.py::test_shared_store_write_and_read_roundtriptests/hermes_cli/test_web_server_oauth_write.py::test_dashboard_oauth_write_uses_owner_only_permissionsThey assert POSIX mode bits unavailable on this Windows host and fail byte-for-byte identically on the pristine pin and candidate. No candidate-related failure was deselected.
Why this matters to users
The extraction removes a self-contained TLS verification cluster from the auth god-file while preserving the existing
hermes_cli.authpatch/import contract. Users get the same TLS behavior with a smaller, independently maintainable module.Links
This PR: refactor(auth): extract TLS verification helpers (S3) #80676
tracker: [COMPLETE] Large-file decomposition: 20/20 done #78647
Auth god-file issue: Shard hermes_cli/auth.py (god-file decomposition) #78637
Merger receipt:
C:/tmp/tg-Feature Package/godfile/auth/extraction/w3/s3-ship-merger-20260806.mdBaseline receipt:
C:/tmp/tg-Feature Package/godfile/auth/extraction/w3/s3-baseline-differential-20260806.jsonPart of #78647
Part of #78637
Scope note
This PR is S3 only. S1 is separately linked in #80673; S4 and S5 remain gated by their own evidence and are not included here.
Credit
The shipped commit is authored and DCO-signed by
andrexibiza <84248988+andrexibiza@users.noreply.github.com>.Interlock
The auth and scoreboard live on #78637. This PR is separately bound to the tracker and file tracker above.
Part of #78647
Part of #78637