fix(discord): auto-thread reply messages - #80658
Open
DaAwesomeRazor wants to merge 1 commit into
Open
Conversation
alt-glitch
added
type/bug
Collaborator
Related: #68941 also changes reply auto-thread behavior, but keeps replies without an explicit mention inline. This focused PR routes every otherwise eligible reply through the configured auto-thread path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
DiscordAdapter._handle_message()explicitly excludeddiscord.MessageType.replyfrom auto-thread creation, so reply messages were dispatched in the parent channel even whendiscord.auto_threadwas enabled.Test plan
scripts/run_tests.sh tests/gateway/test_discord_free_response.py::test_discord_reply_message_auto_threads_when_channel_is_eligible -vscripts/run_tests.sh tests/gateway/test_discord_free_response.py tests/gateway/test_discord_channel_controls.py tests/gateway/test_discord_double_dispatch.py tests/gateway/test_discord_reply_mode.py tests/gateway/test_discord_slash_commands.py tests/e2e/test_discord_adapter.py -v(65 passed)scripts/run_tests.sh tests/gateway/test_discord_*.py(223 passed)