fix(kanban): enforce target skill capability before start - #80638
Closed
sinabahram wants to merge 3 commits into
Closed
fix(kanban): enforce target skill capability before start#80638sinabahram wants to merge 3 commits into
sinabahram wants to merge 3 commits into
Conversation
Collaborator
Related: #33747 and #59793 provide earlier dispatcher-side skill preflight. This PR adds target-profile runtime resolution, create-time validation, CAS-bound preflight/claim handling, and a final child-startup guard; these are competing scope choices rather than duplicate patches. |
Author
|
Closing immediately: this PR was opened without the repository owner's authorization. Please disregard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kanban task-level
skillsare a hard worker capability requirement, but the current dispatch path can accept a task and later start a worker that cannot actually load them. This closes that bug class at each authoritative boundary:not_startedevent discriminator so notifications say "blocked before start" only for authoritative pre-start gates, while runtime capability blocks say only "blocked."No schema, migration, service, endpoint, or generalized state-machine change is introduced.
Relationship to #33747
I reviewed #33747 before preparing this PR. It addresses the same user-visible symptom with a dispatcher-time local skill scan in
hermes_cli/kanban_db.pyplus focused tests. That is useful coverage, but it does not cover the full failure window reproduced here: creation-time validation, runtime-equivalent disabled/plugin/legacy/external resolution, snapshot-bound claim/block CAS, post-claim filesystem drift at child startup, retry/failure accounting, or the explicit notification discriminator.This PR therefore is not a duplicate of that two-file preflight proposal; it fixes the broader capability-invariant and race class while keeping the implementation bounded to the existing Kanban, skill-loading, CLI-startup, and notifier paths.
Test plan
scripts/run_tests.sh tests/hermes_cli/test_kanban_assignee_skill_preflight.py tests/cli/test_cli_preloaded_skills.py tests/gateway/test_kanban_notifier.py -q— 24 passedscripts/run_tests.sh tests/hermes_cli/test_kanban*.py tests/cli/test_cli_preloaded_skills.py tests/gateway/test_kanban_notifier.py -q— 185 passeduv run ruff check agent/skill_commands.py cli.py gateway/kanban_watchers.py hermes_cli/kanban_db.py tests/cli/test_cli_preloaded_skills.py tests/gateway/test_kanban_notifier.py tests/hermes_cli/test_kanban_assignee_skill_preflight.py— passedgit diff --check upstream/main...HEAD— passed