test(delegation): executable class map for fallback-chain resolution (#80450) - #80474
Open
ayushnangia wants to merge 2 commits into
Open
test(delegation): executable class map for fallback-chain resolution (#80450)#80474ayushnangia wants to merge 2 commits into
ayushnangia wants to merge 2 commits into
Conversation
One test per open member of the 'which fallback chain does a non-head agent get?' class (NousResearch#80450 cross-PR map): pinned delegation.provider overridden by inherited chain (NousResearch#80450, PR NousResearch#80465), configured delegation.fallback_providers ignored (NousResearch#65038, PRs NousResearch#80438/NousResearch#80421), explicit-empty chain contract, and the pin+declared-chain composition question (skipped pending the maintainer's precedence call). Members with fixes in flight are xfail(strict=False): the suite is green today, documents the class, and flips to XPASS as each fix lands. Baseline inheritance behavior is guarded green.
Contributor
Author
|
Companion map: #80450 (comment) |
This was referenced Aug 6, 2026
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only companion to the cross-PR map on #80450: an executable definition of the delegation/fallback resolution class — "which fallback chain does a non-head agent get?" No production code changes; nothing here competes with the fixes in flight.
Changes
tests/tools/test_delegation_fallback_class.py, one test per open member:delegation.providermust not inherit the parent chain —xfail, flips to XPASS when fix(delegation): honor pinned delegation.provider — no silent parent-fallback substitution #80465 landsdelegation.fallback_providersmust reach the child —xfail, flips when fix(delegation): honor worker fallback providers #80438 (@wz-heng) / fix(delegation): honor delegation.fallback_providers for child agents #80421 (@andrexibiza) land (delegation.fallback_providers is ignored; delegated workers inherit the parent fallback chain #65038, reported by @mlahatte)xfail, contract per fix(delegation): honor worker fallback providers #80438skipwith the open precedence question from the delegate_task: pinned delegation.provider/model silently replaced at runtime by inherited parent fallback chain #80450 discussion; unskip once decidedAll xfails are
strict=False: the suite is green on main today, and each member's landing turns its test into a visible XPASS — so the audit item on tracker #79686 has a checklist that runs in CI rather than in prose. Chain-entry members (#80209 explicitapi_mode, #79840 benched credentials) and auxiliary-agent members (#79750) carry suites in their own PRs and are referenced in the module docstring rather than duplicated.Validation
scripts/run_tests.sh tests/tools/test_delegation_fallback_class.py: 1 passed, 3 xfailed, 1 skipped, 0 failed. Neighbor suitetests/tools/test_delegate.py: 63/63. Harness reuses_make_mock_parent+ patchedrun_agent.AIAgentfrom the existing delegate tests.Scope notes