feat(plugins): add Telegram callback query hook - #80446
Closed
ITMINDSCAPE wants to merge 9 commits into
Closed
Conversation
Author
|
Superseded by #80458, which contains the final independently reviewed bytes on the corrected v2 branch. |
Collaborator
Related: #21471 is the earlier pre-dispatch callback-hook implementation. This PR proposes a different callback contract but also bundles unrelated cron, Kanban, and terminal changes; a maintainer should choose the extension contract and request a focused scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telegram_callback_queryplugin lifecycle hook for Telegram callbacks not claimed by built-in prefixesTests
scripts/run_tests.sh tests/gateway/test_telegram_callback_plugin_hook.py tests/hermes_cli/test_plugins.py— 53 passedscripts/run_tests.sh tests/gateway/test_telegram*.py— 522 passed across 55 files (one unrelated pytest temp-cleanup retry; the affected file then passed cleanly with retries disabled)HERMES_TEST_FILE_RETRIES=0 scripts/run_tests.sh tests/gateway/test_telegram_forum_commands.py— 2 passedgit diff --cached --check— clean before commitReview
Independent staged-diff review: PASS. Reviewed SHA-256
858d10e122d8fe0d12a21df938f5714fdd922e30a1bcf06be2fd9b5dad07c38a; no files modified by reviewer.