fix(webhook): accept X-Hindsight-Signature - #80329
Open
sg-shag wants to merge 1 commit into
Open
Conversation
alt-glitch
added
type/bug
andrexibiza
added a commit
to andrexibiza/hermes-agent
that referenced
this pull request
Aug 16, 2026
…odes, signature_mode across CLI/REST/desktop, mode-bound test signing Adapts HwangJohn's NousResearch#47849 (GitLab Standard Webhooks wire format: webhook-id/ webhook-timestamp/webhook-signature, signed {id}.{timestamp}.{raw_body}) and sg-shag's NousResearch#80329 (X-Hindsight-Signature sha256=<hex> raw-body contract) into the explicit-mode architecture as dedicated signature modes, preserving attribution. Legacy gitlab mode remains the plaintext X-Gitlab-Token path. - webhook_auth: gitlab_standard + hindsight modes; SIGNATURE_MODES extended - CLI: subscribe --signature-mode persists on the route; test signs per the route's configured mode (all seven wire formats); list shows the mode - REST: WebhookCreate.signature_mode; router persists and summarizes it - Desktop: signature-mode select in the create dialog, detail display, i18n (en/zh), API types - Tests: real wire-format acceptance + cross-mode rejection for both modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Hindsight-Signaturein the generic webhook adaptersha256=<hex>contract already accepted forX-Hub-Signature-256Validation
X-Hub-Signature-256returned200;X-Hindsight-Signaturereturned401for the same signed payload200Closes #80327
Alternative considered
A possible alternative is to make Hindsight emit
X-Hub-Signature-256directly, or allow selecting that header name in Hindsight webhook delivery config. Related Hindsight discussion: vectorize-io/hindsight#3071