fix(gateway): use datetime cutoff in suspend_recently_active - #8026
Closed
tomqiaozc wants to merge 1 commit into
Closed
fix(gateway): use datetime cutoff in suspend_recently_active#8026tomqiaozc wants to merge 1 commit into
tomqiaozc wants to merge 1 commit into
Conversation
suspend_recently_active() compared a datetime (entry.updated_at) to a float (time.time() - max_age_seconds), raising TypeError on every gateway startup. Use _now() - timedelta() to produce a datetime cutoff instead. Fixes NousResearch#7966 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Contributor
|
Thanks for this fix, @tomqiaozc! The datetime vs float Evidence:
Closing as implemented on main. — automated hermes-sweeper review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suspend_recently_active()comparedentry.updated_at(adatetime) totime.time() - max_age_seconds(afloat), raisingTypeError: '>=' not supported between instances of 'datetime.datetime' and 'float'on every gateway startup._now() - timedelta(seconds=max_age_seconds)so the comparison isdatetime >= datetime.Fixes #7966
Test plan
test_suspends_recent_session— session updated 30s ago is suspended (within 120s window)test_skips_old_session— session updated 1h ago is not suspendedtest_no_type_error— regression: no datetime >= float TypeError🤖 Generated with Claude Code