Skip to content

fix(cron): distinguish binary skip from missing file in referenced-script scan #80164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
applex250 wants to merge 1 commit into from
Closed

fix(cron): distinguish binary skip from missing file in referenced-script scan #80164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cron/lifecycle_guard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,11 @@ def _read_referenced_script(path: Path) -> tuple[Optional[str], bool]:
# (including a `ValueError: embedded null byte` from Path.resolve,
# #76762). Treat it as "nothing to scan" rather than unsafe: a binary
# executed by the user is not a referenced *shell script*.
# Return "" (not None) so callers don't mistake "binary, skip" for
# "local file missing" and fall back to read_remote_script, which
# would decode the binary as text and re-enter the junk-path loop.
if b"\x00" in data:
return None, False
return "", False
if len(data) > _MAX_REFERENCED_SCRIPT_BYTES:
return None, True
return data.decode("utf-8", errors="replace"), False
Expand Down