Skip to content

refactor(kanban): extract models + schema into kanban_db_models (kanban_db.py god-file slice R1) - #79893

Open
andrexibiza wants to merge 1 commit into
NousResearch:mainfrom
andrexibiza:fix/kb-models
Open

refactor(kanban): extract models + schema into kanban_db_models (kanban_db.py god-file slice R1)#79893
andrexibiza wants to merge 1 commit into
NousResearch:mainfrom
andrexibiza:fix/kb-models

Conversation

@andrexibiza

@andrexibiza andrexibiza commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

kanban_db.py god-file slice R1: extract the models dataclasses + SCHEMA_SQL (window 904–1377, 474 lines) into hermes_cli/kanban_db_models.py. Part of the repo-wide large-file decomposition (tracker #78647).

What changed and why

  • Task/Run/Comment/Attachment/Event dataclasses + SCHEMA_SQL moved byte-verbatim (golden blob 113e34842ec… verified; difflib delta 0)
  • Stdlib-only (json/sqlite3/dataclasses); zero module-state deps; 9 external importers use the kb. namespace → 1-line re-export shim, zero caller edits
  • Avoids refactor(kanban): extract board-path/integrity/policy mixins from kanban_db.py (shard s1) #79613's board-paths/integrity/policy territory (verified disjoint)
  • Double-blind: 2 analysts → consensus → implementer → 2 blind re-reviewers (both APPROVED)

Testing

  • 7 passed seam tests (identity ×6, no-star-import probe, from_row JSON parsing, schema 7 tables + executes)
  • 38-file region: 19-failure set byte-identical to pristine base (pre-existing env class)
  • ruff clean · git diff --check clean · LF-only · DCO signed

Coordination / interlock

Part of #78647
Part of #78632

…an_db.py god-file slice R1)

Signed-off-by: andrexibiza <84248988+andrexibiza@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cron Cron scheduler and job management P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants