Skip to content

fix(plugins): allow eager platform tool registration - #79665

Closed
josh-hobbs-dawnleap wants to merge 1 commit into
NousResearch:mainfrom
josh-hobbs-dawnleap:josh/a2a-tools-manifest
Closed

fix(plugins): allow eager platform tool registration#79665
josh-hobbs-dawnleap wants to merge 1 commit into
NousResearch:mainfrom
josh-hobbs-dawnleap:josh/a2a-tools-manifest

Conversation

@josh-hobbs-dawnleap

@josh-hobbs-dawnleap josh-hobbs-dawnleap commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • adds manifest-level eager_load: true support for bundled platform plugins
  • marks the bundled A2A platform plugin eager so its outbound a2a_* tools register in normal chat sessions
  • keeps ordinary platform plugins deferred by default
  • adds regression coverage proving eager platform tools register while ordinary platforms remain lazy
  • adds integration coverage loading the real bundled A2A plugin and asserting all five client tools register under the a2a toolset

Why

A2A is both an inbound gateway platform and an outbound agent-to-agent tool provider. Deferring the whole platform plugin means enabled A2A client tools can be missing from normal sessions until inbound platform materialization happens.

Test plan

  • uv run --with pytest pytest tests/hermes_cli/test_plugins.py -q -o addopts=
  • uv run --with pytest pytest tests/plugins/test_a2a_plugin.py -q -o addopts=
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins labels Aug 5, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Closing in favor of PR #86660 (#86660), which fixed the same deferred-platform client-tool registration via the provides_tools mechanism the #78050 thread converged on (#78842 by @thelonewander3r, submitted a day earlier). Thanks for the fix — sorry it was a duplicate swarm.

@teknium1 teknium1 closed this Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants