fix(bluebubbles): use UTC epoch for tempGuid instead of naive local time - #79603
Open
webtecnica wants to merge 1 commit into
Open
fix(bluebubbles): use UTC epoch for tempGuid instead of naive local time#79603webtecnica wants to merge 1 commit into
webtecnica wants to merge 1 commit into
Conversation
Collaborator
Duplicate of #23820: both replace |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway/platforms/bluebubbles.pybuilt temporary message GUIDs withdatetime.utcnow().timestamp().utcnow()returns a naive datetime, and calling.timestamp()on a naive datetime interprets it as local time, not UTC — so the embedded epoch was offset by the machine's UTC offset (e.g. −8h on UTC+8, −3h on UTC−3).Root Cause
Two call sites (line ~513
_create_chat_for_handleand line ~569 chunked send path) useddatetime.utcnow().timestamp(), producing atemp-<epoch>GUID whose timestamp is wrong by the local UTC offset.Change
gateway/platforms/bluebubbles.py: both call sites now usedatetime.now(timezone.utc).timestamp()(correct UTC epoch);timezoneadded to thedatetimeimport.tests/gateway/test_bluebubbles.py: newTestBlueBubblesTempGuidclass asserting both outbound payloads embed a UTC epoch within a 5s tolerance oftime.time()(a local-offset bug drifts by hours, far beyond the window).Verification
tests/gateway/test_bluebubbles.py: 20 passed (18 pre-existing + 2 new).Closes #79511