chore: map zhjay@stu.xjtu.edu.cn to ZHJay - #79418
Open
ZHJay wants to merge 1 commit into
Open
Conversation
Adds the contributors/emails/ mapping for my commit author email so `Check contributors` can attribute the PRs I have open against NousResearch#77472 (NousResearch#77520, NousResearch#77655, NousResearch#77579, NousResearch#77717, NousResearch#78379, NousResearch#78395, NousResearch#78408). Without it that job fails every one of them before a test runs, since it is a required needs: of the all-checks-pass aggregate. One file per email, per the directory's own convention — file additions never merge-conflict, unlike the frozen AUTHOR_MAP in scripts/release.py, which the script and its docstring both say not to append to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
Adds the
contributors/emails/mapping for my commit author email soCheck contributorscan attribute my commits.Without it that job fails, and it is a required
needs:of theall-checks-passaggregate — so it fails before any test runs. That currently blocks all seven PRs I have open against #77472:fix/transcript-artifact-file-modesfix/at-rest-remaining-transcript-sitesfix/browser-profile-media-cache-modesfix/shutdown-flush-managed-modefix/redact-preserves-json-delimitersfix/bound-request-dump-growthfix/trajectory-cwd-git-guardMeasured on
upstream/mainat1be70d635:Landing this first makes the other seven attributable; it is otherwise independent of them.
Changes Made
contributors/emails/zhjay@stu.xjtu.edu.cn— new, 2 lines: the login plus a comment naming the cluster.One file per email, per the directory's own convention.
scripts/add_contributor.pyand its docstring both say the legacyAUTHOR_MAPinscripts/release.pyis frozen and must not be appended to, so this goes in the conflict-free directory instead.How to Test
Generated with the repo's own script rather than by hand, so the filename and content follow whatever it enforces:
Re-running it prints
presentand exits 0 (idempotent), and it refuses with exit 1 if an email already maps to a different login, so a typo cannot silently reassign someone else's commits.The check this satisfies, from
.github/workflows/contributor-check.yml:Note: the script requires Python 3.10+ (
str | Noneannotations). On 3.9 it fails withTypeError: unsupported operand type(s) for |. Not a change in this PR, just what I hit.Platforms Tested
No code paths change, so there is nothing platform-specific to exercise.
Related Issue
Unblocks CI attribution for the seven PRs listed above, which address #77472.