refactor(cli): extract modal/confirm machinery into CLIModalConfirmMixin (cli.py god-file slice R3) - #79367
Open
andrexibiza wants to merge 1 commit into
Open
Conversation
…xin (cli.py god-file slice R3) Signed-off-by: andrexibiza <84248988+andrexibiza@users.noreply.github.com>
This was referenced Aug 5, 2026
Contributor
Author
|
🔒 This shard is part of the cli.py KILL LOCK — the permanent record of the 18,485-line whole, the mess it caused (#54960 duplicate-tracking chaos, #65303 no ESC-interrupt, #72797 XML-tag loss, #75461 redaction bypass, #76914 unfinalized sessions, #77764 approval truncation, #39446 /reload-mcp blocking, terminal-escape leaks), every shard in the wave, the #12355 block on R1, and every open fixer PR still fighting the surface (#73104 #75476 #77776 #75084 #76804 #76995 #71295 #78871 #74491 #72821 #57453 #61429 #71027 #62027 #65192 #71088 #74038 #69918 #67484 #12355 #75207 #32193 #74281 #37818 #27172 #65785). Lock: posted on #55136 · Indexed by the Kill All Gods meta-issue #78647. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli.py god-file slice R3: extract the modal/confirm machinery from
cli.pyintohermes_cli/cli_modal_confirm_mixin.py(classCLIModalConfirmMixin). Part of the repo-wide large-file decomposition (tracker #78647).What changed and why
_run_curses_picker,_prompt_text_input,_prompt_text_input_modal,_submit_slash_confirm_response,_normalize_slash_confirm_choice,_get_slash_confirm_display_fragments) moved byte-verbatim (golden shab38e6f4b…verified)queue/shutil/sys/textwrap+ lazy in-function imports) — the cleanest slice in R3CLIModalConfirmMixinappended last toHermesCLIbases; zero__init__change;_run_curses_pickerhas zero callers at pin (moved verbatim anyway; dead-code retirement is a separate diff)Testing
test_cli_modal_confirm_seam.py: 18 passed (identity asserts 6/6, no-back-import subprocess, modal-flow, slash-confirm normalization, display fragments)tests/cli: 938/934 passed — identical 4 failures reproduced at base (pre-existing/environmental)Coordination / interlock
Part of #78647
Part of #55136