refactor(cli): extract Petdex mascot cluster into CLIPetMixin (cli.py god-file slice R2) - #79365
Open
andrexibiza wants to merge 1 commit into
Open
refactor(cli): extract Petdex mascot cluster into CLIPetMixin (cli.py god-file slice R2)#79365andrexibiza wants to merge 1 commit into
andrexibiza wants to merge 1 commit into
Conversation
… god-file slice R2) Move the 13-member Petdex mascot cluster (banner + _PET_FRAME_INTERVAL, _PET_CFG_INTERVAL + 11 _pet*/_on_reaction methods, cli.py window 5613-5829 at pin aec3318) byte-verbatim into hermes_cli/cli_pet_mixin.py as CLIPetMixin, appended last to HermesCLI's base tuple. Identity-preserving seam: all members resolve via MRO; no __init__ change; zero caller edits (all 7 out-of-cluster call sites are same-class). Part of NousResearch#55136 Signed-off-by: andrexibiza <84248988+andrexibiza@users.noreply.github.com>
This was referenced Aug 5, 2026
Contributor
Author
|
🔒 This shard is part of the cli.py KILL LOCK — the permanent record of the 18,485-line whole, the mess it caused (#54960 duplicate-tracking chaos, #65303 no ESC-interrupt, #72797 XML-tag loss, #75461 redaction bypass, #76914 unfinalized sessions, #77764 approval truncation, #39446 /reload-mcp blocking, terminal-escape leaks), every shard in the wave, the #12355 block on R1, and every open fixer PR still fighting the surface (#73104 #75476 #77776 #75084 #76804 #76995 #71295 #78871 #74491 #72821 #57453 #61429 #71027 #62027 #65192 #71088 #74038 #69918 #67484 #12355 #75207 #32193 #74281 #37818 #27172 #65785). Lock: posted on #55136 · Indexed by the Kill All Gods meta-issue #78647. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli.py god-file slice R2: extract the Petdex mascot cluster from
cli.py(18,485 lines) intohermes_cli/cli_pet_mixin.py(classCLIPetMixin). Part of the repo-wide large-file decomposition (tracker #78647).What changed and why
_PET_FRAME_INTERVAL,_PET_CFG_INTERVAL+ 11 methods) moved 218/218 bytes byte-exact intohermes_cli/cli_pet_mixin.pyHermesCLI(CLIAgentSetupMixin, CLICommandsMixin, CLIBillingMixin, CLIPetMixin)— mixin appended last; zero__init__change, zero caller edits; all 7 out-of-cluster call sites resolve through the MRO__future__/threading/time;agent.pet.*+hermes_cli.configstay lazy in-method (as in the original)Testing
test_cli_pet_mixin_seam.py: 13 identity asserts (getattr(HermesCLI, n) is CLIPetMixin.n), MRO-order/no-shadowing assert, no-back-import subprocess test (sys.modules['cli']=None), import-order permutation, patch-binding-through-seam, anim-loop idempotency,_on_reactionflashtest_cli_pet_pane.py+test_cli_status_bar.py+test_cli_init.py+test_cli_active_agent_ref_wiring.py): 50 passedCoordination / interlock
Part of #78647
Part of #55136