Skip to content

⌘1 / ⌃Tab return to the chat from a full-page view - #78679

Merged
OutThisLife merged 1 commit into
mainfrom
bb/tab-keys-leave-pages
Aug 4, 2026
Merged

⌘1 / ⌃Tab return to the chat from a full-page view#78679
OutThisLife merged 1 commit into
mainfrom
bb/tab-keys-leave-pages

Conversation

@OutThisLife

Copy link
Copy Markdown
Collaborator

Hitting ⌘1 (or ⌃Tab-cycling onto the main tab) while a full page — Capabilities, Messaging, Artifacts, or a plugin route — covered the workspace read as a dead key: the workspace pane was already the zone's active tab behind the page, so fronting it changed nothing on screen. Only a route change puts the chat back, which is the rule openSession already applies from full pages.

activateTreeTabSlot / cycleTreeTabInFocusedZone now return the activated pane id instead of a boolean, and the keybind handlers route back to the loaded session (or the new-chat draft) when the key lands on the workspace tab under a full page. Falls back to profile switch / recent-session switcher exactly as before when no tab strip claims the key.

Hitting ⌘1 (or cycling ⌃Tab onto the main tab) while Capabilities /
Messaging / Artifacts covered the workspace looked dead: the workspace
pane was already the zone's active tab behind the page, so fronting it
changed nothing on screen.

activateTreeTabSlot / cycleTreeTabInFocusedZone now return the activated
pane id, and the keybind handlers route back to the loaded session (or
the new-chat draft) when the landing pane is the workspace under a full
page — the same rule openSession already applies.
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 91337e5

all good!

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) labels Aug 4, 2026
@OutThisLife
OutThisLife enabled auto-merge August 4, 2026 17:35
@OutThisLife
OutThisLife merged commit be55e99 into main Aug 4, 2026
37 checks passed
@OutThisLife
OutThisLife deleted the bb/tab-keys-leave-pages branch August 4, 2026 17:39
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
…eave-pages

⌘1 / ⌃Tab return to the chat from a full-page view
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
…eave-pages

⌘1 / ⌃Tab return to the chat from a full-page view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants