fix(supermemory): honor auto capture across lifecycle flushes - #78656
Open
CryptoKylan wants to merge 1 commit into
Open
fix(supermemory): honor auto capture across lifecycle flushes#78656CryptoKylan wants to merge 1 commit into
CryptoKylan wants to merge 1 commit into
Conversation
CryptoKylan
marked this pull request as ready for review
August 4, 2026 16:52
Collaborator
@Dhravya @MaheshtheDev Tagging you on this Supermemory provider item as the soft maintainers. |
CryptoKylan
force-pushed
the
fix/supermemory-auto-capture-lifecycle-reviewed
branch
from
August 11, 2026 01:27
fbe45db to
8aebbb7
Compare
Author
|
Refreshed onto current Current validation:
GitHub now reports the refreshed head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an
auto_capture: falsepolicy leak in the bundled Supermemory provider.sync_turn()already obeyed this setting, but three independent automatic lifecycle flushes bypassed it:on_session_end()(including compaction/session boundaries),on_session_switch(), andAll three now honor the same policy. Explicit user-intent writes through
supermemory_storeandon_memory_write()remain available when automatic capture is disabled.Follow-up to #21690 / #21692. Replaces #78617, which became stuck on a stale fork head after a reviewed amendment.
Independent review
The final diff was independently reviewed by provenance-verified
claude-opus-5(high confidence;pass_with_watchlist, no blocking defects). One state bookkeeping issue found during the first review was repaired with a failing regression before the second review.Validation