Conversation
Collaborator
|
Resolved via PR #97008, which salvaged the heal-or-fallback fix for stale-provider session resume onto current main (based on #96111, with #78947 as the earliest submission of the fallback half — both credited). The Desktop can now recover sessions after provider removal: renamed providers heal to the new identity, deleted ones fall back to the configured default. Thanks for your work on this bug class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a persisted session references a provider that has since been removed from configuration, Desktop/TUI resume could restore the stale provider identity and endpoint metadata before the model picker became usable.
This change makes stored runtime restoration validate the provider identity against the current provider registry. If the provider is no longer routable, the restored session keeps its model and session-local reasoning/service-tier settings but drops the stale provider, base URL, and API mode. The session can then initialize with the current default provider and be switched through the existing session-scoped model picker.
Scope
Tests
python -m pytest tests/test_tui_gateway_server.py -q— 518 passedpython -m py_compile tui_gateway/server.pygit diff --check