Skip to content

fix: lifecycle guard crashes on referenced scripts with embedded NUL byte paths #78506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Duncan822 wants to merge 2 commits into from
Closed

fix: lifecycle guard crashes on referenced scripts with embedded NUL byte paths #78506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce03753
fix: guard os.open against embedded NUL byte paths in lifecycle guard
Aug 4, 2026
1daf34b
fix: skip binary content from remote script fallback in lifecycle guard
Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cron/lifecycle_guard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,11 @@ def _read_referenced_script(path: Path) -> tuple[Optional[str], bool]:
flags = os.O_RDONLY | getattr(os, "O_NONBLOCK", 0)
try:
descriptor = os.open(path, flags)
except OSError:
except (OSError, ValueError):
# OSError: unreadable/long paths. ValueError: a path containing an
# embedded NUL byte (e.g. a binary's decoded contents tokenized as a
# path) — os.open raises ValueError for those, and a guarded path
# must never crash the guard (#76762). Treat both as "nothing to scan".
return None, False
try:
metadata = os.fstat(descriptor)
Expand Down Expand Up @@ -327,6 +331,12 @@ def _contains_unsafe_gateway_action(
if script_text is None and read_remote_script is not None:
# Local path missing; try the remote backend if one is available.
script_text = read_remote_script(str(script_path))
# The remote fallback may return raw binary decoded as text (e.g.
# `cat` of an ELF executable). NUL bytes mean binary — treat as
# "nothing to scan", mirroring the local-path NUL guard above,
# so a binary can't explode the recursion or false-positive.
if script_text and "\x00" in script_text:
script_text = None
if not script_text:
continue
# Relative references inside a script resolve against that script's
Expand Down