Conversation
Author
|
Closing this PR to avoid duplicating the direct fix in #78095. Review confirmed that the underlying failure is the 120-character command-line truncation that hides the trailing The compatibility-message change in this PR is not the correct primary fix for the reported failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, an older or stale Desktop updater can still report a real Hermes gateway as a venv blocker. The resulting dialog only says to close a terminal/app/service, even though the process is a Hermes gateway and the correct recovery is
hermes gateway stopfollowed by retrying the update.This patch adds a conservative compatibility check for the exact
python -m hermes_cli.main gateway runshape and appends gateway-specific recovery guidance. It does not change the blocker decision, stop processes automatically, or replace the Python updater's canonical gateway classification. Generic blockers keep the existing message.Reproduction evidence
The attached screenshots show the full flow:
python.exe -m hermes_cli.main gateway runRelated
python -m http.server.Validation
npm run test:desktop:platforms -- electron/venv-blocker-scan.test.ts— 24 passednpm run typecheck— passedScreenshots will be attached to this description.