Skip to content

fix(desktop): give gateway-specific recovery for updater blockers - #78372

Closed
skyzea1 wants to merge 1 commit into
NousResearch:mainfrom
skyzea1:fix/desktop-gateway-update-hand-off
Closed

skyzea1 wants to merge 1 commit into
NousResearch:mainfrom
skyzea1:fix/desktop-gateway-update-hand-off

Conversation

@skyzea1

@skyzea1 skyzea1 commented Aug 4, 2026

Copy link
Copy Markdown

Summary

On Windows, an older or stale Desktop updater can still report a real Hermes gateway as a venv blocker. The resulting dialog only says to close a terminal/app/service, even though the process is a Hermes gateway and the correct recovery is hermes gateway stop followed by retrying the update.

This patch adds a conservative compatibility check for the exact python -m hermes_cli.main gateway run shape and appends gateway-specific recovery guidance. It does not change the blocker decision, stop processes automatically, or replace the Python updater's canonical gateway classification. Generic blockers keep the existing message.

Reproduction evidence

The attached screenshots show the full flow:

  1. Update available dialog
  2. Hermes restarting while the updater takes over
  3. Update aborting with PID 20132 and python.exe -m hermes_cli.main gateway run

Related

Validation

  • npm run test:desktop:platforms -- electron/venv-blocker-scan.test.ts — 24 passed
  • npm run typecheck — passed
  • targeted ESLint — passed
  • Prettier check — passed
  • repository lint — passed with 88 pre-existing warnings in unrelated files

Screenshots will be attached to this description.

@skyzea1

skyzea1 commented Aug 4, 2026

Copy link
Copy Markdown
Author

Closing this PR to avoid duplicating the direct fix in #78095. Review confirmed that the underlying failure is the 120-character command-line truncation that hides the trailing gateway run tokens during preflight classification. The screenshots are being added as reproduction evidence to #78095 instead.

The compatibility-message change in this PR is not the correct primary fix for the reported failure.

@skyzea1 skyzea1 closed this Aug 4, 2026
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) platform/windows Native Windows-specific behavior or breakage sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have platform/windows Native Windows-specific behavior or breakage sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants