fix(gateway): bound SQLite file descriptor usage - #78287
Open
injooinjoo wants to merge 1 commit into
Open
Conversation
19 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionStore's existingSessionDBinstead of creating a second long-lived instanceSessionDB.close()actually releases their descriptorsSessionDBshutdown when the runner and store share one instanceReproduction
A long-lived macOS gateway with launchd's soft
RLIMIT_NOFILE=256reached 252 numeric descriptors. 145 werestate.db/ WAL descriptors.GatewayRunnercreated twoSessionDBinstances, and each retained one WAL reader connection per worker thread. In addition, readers were opened with SQLite's defaultcheck_same_thread=True, so the owner-thread close loop raisedProgrammingErrorand silently left worker-created descriptors open.Verification
scripts/run_tests.sh tests/test_hermes_state.py tests/test_session_db_read_path_split.py tests/gateway/test_session.py tests/gateway/test_gateway_shutdown.py tests/gateway/test_runner_session_db_fd_budget.py -qmainSessionDB.close()state.dbFDs, stable for 60 seconds; Slack auth remained healthy