feat(desktop): restore session when switching profiles - #77957
Open
zaycruz wants to merge 2 commits into
Open
Conversation
Author
Adversarial quality gate — GREENIteration 2 passed all required available gates on base and head:
Adversarial review found no MUST-FIX findings. ACCEPTABLE-RISK:
The durable Markdown and HTML reports are saved locally at:
The gate caught and corrected false local failures caused by invalid Node localStorage setup and incomplete baseline dependencies before assigning the final result. |
9 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #77952.
Hermes Desktop already stores the last route and session per profile for cold-start restore. Profile switching still discarded the foreground session and opened a fresh draft. This change uses the existing per-profile state for live profile switching.
Behavior
Verification
npx vitest run --project ui src/store/profile.test.ts— passed, 15 tests.npm run typecheck— passed.npx prettier --check src/app/contrib/wiring.tsx src/store/profile.ts src/store/profile.test.ts— passed.npm run build— passed.npm run lint -- --quiet— blocked because the workspace install did not linkeslint.localStoragestub has nosetItem,removeItem, orclearmethods. The changed profile test passes independently.