fix(bluebubbles): raise send_file timeout to cover slow uploads (#77918) - #77940
Open
webtecnica wants to merge 1 commit into
Open
fix(bluebubbles): raise send_file timeout to cover slow uploads (#77918)#77940webtecnica wants to merge 1 commit into
webtecnica wants to merge 1 commit into
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #77918. The BlueBubbles attachment upload in
_send_attachmentused a hardcodedtimeout=120, but on macOS 26 a successful attachment send routinely takes ~2 minutes to return. The client-side timeout fired first,_send_attachmentreturnedSendResult(success=False), and the user saw "Couldn't deliver the file attachment" moments after the file actually arrived.Root Cause
gateway/platforms/bluebubbles.pyposted to/api/v1/message/attachmentwithtimeout=120, well below BlueBubbles Server's own internal upload timeout of 300s. The gateway log showed the failure warning exactly 120s after the send started, even though delivery succeeded.Change
BlueBubblesAdapter.ATTACHMENT_UPLOAD_TIMEOUT = 300, matching BlueBubbles Server's own 300s internal limit, and used it for the attachment upload request instead of the hardcoded 120s.Verification
TestBlueBubblesAttachmentUpload::test_send_attachment_uses_300s_upload_timeoutasserts_send_attachmentposts to/api/v1/message/attachmentwithtimeout == 300and returns success.19 passed.Closes #77918