fix: hashlib.sha1 FIPS crash in tui_gateway/server.py and optional-skills/dossier.py - #77745
Open
JonthanaHanh wants to merge 1 commit into
Open
Conversation
Add usedforsecurity=False to hashlib.sha1 calls in: - tui_gateway/server.py:11677 — revision hash for MCP config change detection - optional-skills/security/unbroker/scripts/dossier.py:25 — opaque subject ID generation Both calls use SHA-1 for non-security purposes (content hashing, ID generation). On FIPS-enabled systems (RHEL 8/9), hashlib.sha1() without usedforsecurity=False raises ValueError: EVP_DigestInit_ex disabled for FIPS. This is the same pattern fixed in prior PRs for other files (NousResearch#56715, NousResearch#56716, NousResearch#56719, NousResearch#62654, NousResearch#64062, NousResearch#66857). These two call sites were missed in those batches.
Collaborator
Duplicate of #77391: the current patch changes the same two FIPS SHA-1 call sites with the same |
This was referenced Aug 5, 2026
refactor(tui): extract pet payload into tui_gateway/pet_payload (server.py god-file slice R3)
#79261
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
usedforsecurity=Falseto two remaininghashlib.sha1()calls that crash on FIPS-enabled systems (RHEL 8/9).Changes
tui_gateway/server.py:11677— revision hash for MCP config change detectionoptional-skills/security/unbroker/scripts/dossier.py:25— opaque subject ID generationBoth calls use SHA-1 for non-security purposes (content hashing, unique ID generation). On FIPS-enabled systems,
hashlib.sha1()withoutusedforsecurity=FalseraisesValueError: EVP_DigestInit_ex disabled for FIPS.Background
This is the same pattern fixed in prior PRs for other files:
These two call sites were missed in those earlier batches. SHA-256 is FIPS-approved and does not need this parameter.