Conversation
Contributor
…path When a profile is active, HERMES_HOME is already profile-scoped (e.g. ~/.hermes/profiles/foo), but the active-profile hint appended /profiles/<name>/ again, fabricating a non-existent nested path like ~/.hermes/profiles/foo/profiles/foo/. The session's own data lives at HERMES_HOME itself; the default profile's data lives under the root. Fixes the phantom nested profile dir shown to agents in profile-scoped desktop sessions. Adds a regression test covering the non-default profile branch.
33hodl
force-pushed
the
fix/profile-prompt-nested-path
branch
from
August 10, 2026 10:30
4594a1b to
f9940c0
Compare
Contributor
Author
|
Closing as a duplicate of #74979, which fixes the same doubled-profile-path defect with stronger integration tests that drive the real resolver chain (this PR mocked the resolver instead). Deferring to that PR — thanks for the thorough work there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a named profile is active,
HERMES_HOMEis already profile-scoped (e.g.~/.hermes/profiles/setup-radar-lab), butagent/system_prompt.py's active-profile hint appended/profiles/<name>/again, fabricating a non-existent nested path like:Agents in profile-scoped desktop sessions were told their session reads/writes a phantom directory. The session's own data actually lives at
HERMES_HOMEitself; the default profile's data lives under the root (parent ofprofiles/).Change
HERMES_HOMEdirectly.get_default_hermes_root()instead of being mis-derived from the profile-scoped home.test_profile_prompt_no_nested_profiles_pathcovers the non-default profile branch.Test plan