fix(gateway): skip systemd check when systemctl is absent - #7771
Closed
nocelery-ai wants to merge 1 commit into
Closed
fix(gateway): skip systemd check when systemctl is absent#7771nocelery-ai wants to merge 1 commit into
nocelery-ai wants to merge 1 commit into
Conversation
`supports_systemd_services()` unconditionally returns `True` on Linux,
but Docker containers typically lack systemd/systemctl. This causes
`hermes gateway setup` to crash with a `FileNotFoundError` when it
tries to invoke `systemctl is-active`.
Guard with `shutil.which("systemctl")` before assuming systemd support.
darkweb010110-coder
approved these changes
Apr 11, 2026
Contributor
|
Closing as duplicate — this issue is fixed in #8614 (salvaged from @alt-glitch's comprehensive #8573). Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes gateway setupcrashes withFileNotFoundErrorin Docker containers becausesupports_systemd_services()returnsTrueon all Linux, but Docker lackssystemctlshutil.which("systemctl")guard before assuming systemd supportTest plan
hermes gateway setupcompletes successfully inside Docker containersystemctlbinary is missing)