fix(ws): TOCTOU race in close_on_disconnect - #77535
Closed
eaglezzz0522-cloud wants to merge 1 commit into
Closed
Conversation
_close_sessions_for_transport() now snapshots session IDs outside _sessions_lock, then re-validates each session under _session_resume_lock -> _sessions_lock before acting. Prevents RuntimeError from mutating _sessions dict during iteration; reconnecting session is never silently closed or detached. Closes NousResearch#77192
alt-glitch
added
type/bug
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_close_sessions_for_transport()now snapshots session IDs outside_sessions_lock, then re-validates each session under_session_resume_lock -> _sessions_lockbefore acting.Prevents
RuntimeErrorfrom mutating_sessionsdict during iteration; reconnecting session is never silently closed or detached.Related
Closes #77192
Validation