fix(buzz): implement send_image_file for local uploads - #77448
Closed
686f6c61 wants to merge 1 commit into
Closed
Conversation
send_images dispatches file:// paths to send_image_file; the Buzz adapter only overrode send_image, so local images hit the base stub. Delegate to the existing local --file upload path. Fixes NousResearch#77392
alt-glitch
added
type/bug
Collaborator
Contributor
Author
|
Duplicate of #74999 (earlier + broader coverage). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlatformAdapter.send_imagesroutes local files throughsend_image_file. Buzz only implementedsend_image, so local image delivery fell through to the base stub ("Couldn't deliver the image attachment") even though CLI--fileupload already works insend_image(#77392).Changes
send_image_fileto delegate tosend_imagewith the local path--fileTest plan
pytest tests/gateway/test_buzz_adapter.py -k send_imageFixes #77392