fix(desktop): memoize sidebar flatRows and row renderers (#75714 salvage) - #77328
Merged
kshitijk4poor merged 3 commits intoAug 3, 2026
Merged
Conversation
…croll jitter (fixes NousResearch#73629) Fix direction inspired by PR NousResearch#73674 by @drbronson with added Vitest component unit tests.
Review follow-up on the NousResearch#75714 salvage: perfectionist/sort-imports would fail lint CI; autofixed.
kshitijk4poor
enabled auto-merge (rebase)
August 3, 2026 04:23
4 tasks
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #75714 by @StanleyStetson — both commits cherry-picked to preserve authorship (rebased clean), plus one lint follow-up commit.
Context — what this changes for users
Sidebar scrolling jittered because every render handed VirtualSessionList a FRESH flatRows array — same data, new identity — re-rendering the whole virtualized tree for nothing (the desktop guide's "preserve reference identity on no-ops" invariant). Memoizing flatRows (and the row renderers) keeps the reference stable across unrelated re-renders; the PR's second commit adds tests that pin exactly this (identity stable across re-render, changed when sessions actually change — verified regression-sensitive: removing the memo or either dep fails them).
Review & verification (real vitest runs)
Follow-up commit
Closes #75714.