fix(desktop): stop app-managed gateway on backend shutdown - #77297
Closed
QuarkAssistant wants to merge 3 commits into
Closed
QuarkAssistant wants to merge 3 commits into
QuarkAssistant wants to merge 3 commits into
Conversation
QuarkAssistant
marked this pull request as ready for review
August 3, 2026 03:34
QuarkAssistant
force-pushed
the
fix/77276-desktop-gateway-orphan
branch
from
August 11, 2026 00:47
cfcaf98 to
2509601
Compare
Collaborator
|
Merged via PR #83542 — your commit(s) were cherry-picked onto current main with your authorship preserved in git log (rebase merge). Thank you for the contribution! This follow-up PR completed the EMFILE hardening cluster after #83406: restart-path gateway orphan reap, Desktop-managed gateway termination on serve shutdown, SSH-spawn ulimit raise, and the dashboard iterdir→scandir fd-leak fixes. Everything was live-tested end-to-end on a real serve backend before merge, including a hostile unreadable-profile-dir fixture that surfaced (and fixed) a pre-existing /api/profiles 500 along the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainby covering graceful Desktop backend shutdowngateway-restartchild when the Desktopservelifespan exitsTDD evidence
uv run pytest tests/hermes_cli/test_dashboard_admin_endpoints.py::test_desktop_lifespan_terminates_managed_gateway_restart -qfailed because the gateway child was not terminated327 passed, 1 skippeduv run ruff check .passed944 file(s) scanned, no findings-15Fixes #77276