fix(buzz): keep progress messages in thread - #77080
Conversation
|
Thanks for the focused fix. The current-main premise is confirmed: Suggested changes
Automated hermes-sweeper review. |
df36c6c to
1e057a8
Compare
|
Implemented the suggested adapter-level coverage. The new regression test verifies that thread_id metadata is translated into the Buzz CLI --reply-to argument. The focused suite now passes 74 tests. Thanks for the suggestion! |
Use the triggering Buzz event as the synthetic thread root when an inbound source has no existing thread. This mirrors the upstream behavior proposed in PR NousResearch#77080 and complements canonical inbound root preservation. Co-authored-by: Hafiz Ahmad Ashfaq <28647270+ahmadashfq@users.noreply.github.com> Signed-off-by: Hafiz Ahmad Ashfaq <28647270+ahmadashfq@users.noreply.github.com>
What does this PR do?
Keeps Buzz progress and status messages in the same conversation as the event that triggered the agent run.
Buzz inbound events do not populate
source.thread_id. Normal final replies still carry the triggering event ID, but the generic progress-routing helper only synthesized that fallback for Slack and Mattermost. Consequently, enabled progress, heartbeat, and interim status messages were sent without a reply anchor and appeared as unrelated top-level Buzz channel posts.This change gives Buzz the same triggering-event fallback. The existing Buzz adapter then sends the event ID through
--reply-to, while an explicit source thread ID continues to take precedence.Related Issue
No linked issue. Reproduced against current
mainand verified on a hosted Buzz gateway.Type of Change
Changes Made
gateway/run.py_resolve_progress_thread_id()'s triggering-event fallback.tests/gateway/test_buzz_progress_thread_routing.pywebsite/docs/user-guide/messaging/buzz.mdtests/gateway/test_buzz_adapter.pythread_idmetadata is translated into the Buzz CLI--reply-toflag.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passThe focused cross-platform progress-routing and Buzz adapter suites pass: 74 passed. The full repository suite was not run for this focused four-file change.
Documentation & Housekeeping
docs/, docstrings) — updated the canonical Buzz guidecli-config.yaml.exampleif I added/changed config keys — N/A; no configuration keys changedCONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/A; no architecture or contributor workflow changedScreenshots / Logs
Live verification on a hosted Buzz gateway confirmed that progress and interim feedback remained in the originating thread after deployment and restart.