fix(kanban): preserve orchestrator lifecycle - #77060
Open
voidfreud wants to merge 2 commits into
Open
Conversation
teknium1
reviewed
Aug 2, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tracing the dispatcher lifecycle end-to-end. The premise is real: current main tells dispatcher-scoped orchestrators to fan out in agent/prompt_builder.py:254-266, but excludes those same workers from the routing gate in tools/kanban_tools.py:111-124; kanban_create and kanban_link use that gate at tools/kanban_tools.py:2210-2234.
Problems
tools/kanban_tools.py:60changes the establishedtoolsets: [kanban]contract to an exclusiveplatform_toolsets.clilookup. The original two-tier routing commit,2704e7b67e, explicitly establishedtoolsets: [kanban]for orchestrators. Please retain compatibility or provide a migration plus coverage.- The changed
default_assigneedocumentation is inaccurate.hermes_cli/kanban_decompose.py:201-214falls back to the active profile ordefault, and lines 252-268 rewrite invalid/absent decomposition assignees to that fallback.
Suggested changes
- Keep the legacy configuration path working while recognizing the platform-scoped form, and test a real dispatcher-spawned routing profile.
- Restore the documented fallback behavior for
kanban.default_assignee.
Automated hermes-sweeper review.
Collaborator
Related: #64186 and #68608 both change Kanban guidance dispatch. This PR adopts a broader lifecycle and routing contract, including dispatcher-spawned orchestrators and dependency resumption; maintainers should choose the intended contract rather than treating these as duplicates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kanban_createreject unknown profile assignees before creating stranded cardsreview-requireddeadlocksVerification
uv run --extra dev pytest tests/tools/test_kanban_tools.py tests/agent/test_prompt_builder.py -q— 90 passed, 1 skippeduv run --extra dev pytest tests/agent/test_system_prompt.py tests/test_model_tools.py tests/hermes_cli/test_kanban_worker_spawn_toolsets.py -q— 33 passeduv run --extra dev pytest tests/hermes_cli/test_kanban_notify.py tests/gateway/test_kanban_notifier.py tests/tui_gateway/test_kanban_notify_poller.py -q— 21 passeduv run --extra dev ruff check ...— clean