Skip to content

fix(doctor): support local Mem0 and quoted profile aliases - #77058

Open
Niraven wants to merge 2 commits into
NousResearch:mainfrom
Niraven:fix/doctor-local-mem0-alias
Open

fix(doctor): support local Mem0 and quoted profile aliases#77058
Niraven wants to merge 2 commits into
NousResearch:mainfrom
Niraven:fix/doctor-local-mem0-alias

Conversation

@Niraven

@Niraven Niraven commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • validate complete local Mem0 OSS configuration in Doctor without requiring a cloud API key
  • parse quoted profile aliases through the shared profile-wrapper path
  • report orphaned profile aliases consistently

Verification

  • targeted regressions passed
  • profile and Doctor suites: 95 passed
  • one pre-existing Vercel diagnostic test remains red and is untouched by this diff

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard tool/memory Memory tool and memory providers area/memory Memory subsystem: store, providers, sync, background reviews area/profiles Multi-profile isolation, HERMES_HOME scoping sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades needs-decision Awaiting maintainer decision before any implementation labels Aug 2, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Related: #59865 and #57931. Both repair the Mem0 OSS doctor path, but this patch uses OSS-config validation and also fixes quoted profile-wrapper aliases, while #59865 validates provider credentials and setup defaults. Please choose or consolidate the overlapping doctor repair.

@teknium1

teknium1 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thanks for fixing two verified CLI defects: current main requires a top-level API key for every Mem0 mode (hermes_cli/doctor.py:2667-2681) and splits quoted wrapper targets incorrectly (hermes_cli/profiles.py:599-607).

Problems

  • The new OSS success path only uses validate_oss_config, which validates sections/provider IDs but not credentials (plugins/memory/mem0/_oss_providers.py:67-87). OpenAI is a supported OSS LLM and embedder with needs_key=True / OPENAI_API_KEY (plugins/memory/mem0/_oss_providers.py:9-14,27-33), so a missing key would now be reported as configured.
  • The OSS wizard writes provider secrets to .env, not the saved oss structure (plugins/memory/mem0/_setup.py:180-186,475-477); the new tests do not cover this credential path.

Suggested changes

  • Make the doctor branch resolve per-provider credential requirements from the existing OSS registries, allowing keyless Ollama while failing missing keyed providers with their configured env-var hint.
  • Add OpenAI-with-key, OpenAI-without-key, and keyless-Ollama doctor regressions. The member discussion links overlapping fix(memory): support Mem0 OSS mode in doctor + setup wizard #59865, whose updated approach is relevant for consolidation.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform area/install-update Installer, updater, packaging, wheels, doctor labels Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/install-update Installer, updater, packaging, wheels, doctor area/memory Memory subsystem: store, providers, sync, background reviews area/profiles Multi-profile isolation, HERMES_HOME scoping comp/cli CLI entry point, hermes_cli/, setup wizard needs-decision Awaiting maintainer decision before any implementation P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants