fix(kanban): secure remediation handoff identity - #76986
Closed
solovision24 wants to merge 19 commits into
Closed
Conversation
…026.7.20 upgrade - agent/conversation_loop.py: prioritise structured reasoning fields over inline-think content for tool_progress_callback relay - ui-tui appLayout.tsx: drop stale inputHeight box sizing (auto-size from rendered content instead) - ui-tui textInput.tsx: cancel pending fast-echo parent update on submit
Merged after independent verification: 54 focused lifecycle/tool/core tests passed, compileall and git diff --check passed, and the PR is limited to the upstream-compatible Hermes baseline.
* fix(kanban): allow requeued review workers past PR guard * fix(kanban): preserve review routing after crash requeue * fix(kanban): preserve native review lane on crash * fix(kanban): apply retry guards to native reviews * fix(kanban): guard native review respawns during cooldown --------- Co-authored-by: SoLo <solo@SoLoBot>
Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): restore native GitHub PR ingest * fix(kanban): restore GitHub PR lifecycle safeguards --------- Co-authored-by: SoLo <solo@SoLoBot>
* feat(kanban): enforce native review lifecycle * fix(kanban): authorize review changes from active review runs --------- Co-authored-by: SoLo <solo@SoLoBot>
* feat(kanban): enforce native review lifecycle * fix(kanban): authorize review changes from active review runs * ci: scope contributor checks to the PR base --------- Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): replay native review convergence on current base * fix(kanban): restore same-card review remediation lifecycle * fix(kanban): replay webhook review convergence on approved base --------- Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): finalize claimed webhook review runs * fix(kanban): correct native review handoff comment --------- Co-authored-by: SoLo <solo@SoLoBot>
Author
|
Closing as an unintended wrong-base artifact created during an internal SoLo fork remediation. The canonical review remains on solovision24/hermes-agent PR #14; no upstream merge is requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
HERMES_PYTHON=/home/solo/.hermes/hermes-agent/venv/bin/python bash scripts/run_tests.sh tests/hermes_cli/test_kanban_review_lifecycle.py tests/hermes_cli/test_kanban_db.py tests/tools/test_kanban_tools.py -q— 94 passedgit diff --check— passednpm run check— blocked by pre-existing missing workspace dependencies (@tauri-apps/api,@assistant-ui/*,@nous-research/ui,plist, and related type errors); no changed JS files.Kanban Task
Deployment implications: no deployment or restart performed; this is a Kanban database/CLI behavior change and requires normal review before merge.