Skip to content

Dev/hermes upgrade t 16bbffad - #76853

Open
solovision24 wants to merge 15 commits into
NousResearch:mainfrom
solovision24:dev/hermes-upgrade-t_16bbffad
Open

Dev/hermes upgrade t 16bbffad#76853
solovision24 wants to merge 15 commits into
NousResearch:mainfrom
solovision24:dev/hermes-upgrade-t_16bbffad

Conversation

@solovision24

Copy link
Copy Markdown

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

solovision24 and others added 11 commits July 31, 2026 08:14
…026.7.20 upgrade

- agent/conversation_loop.py: prioritise structured reasoning fields over
  inline-think content for tool_progress_callback relay
- ui-tui appLayout.tsx: drop stale inputHeight box sizing (auto-size from
  rendered content instead)
- ui-tui textInput.tsx: cancel pending fast-echo parent update on submit
Merged after independent verification: 54 focused lifecycle/tool/core tests passed, compileall and git diff --check passed, and the PR is limited to the upstream-compatible Hermes baseline.
* fix(kanban): allow requeued review workers past PR guard

* fix(kanban): preserve review routing after crash requeue

* fix(kanban): preserve native review lane on crash

* fix(kanban): apply retry guards to native reviews

* fix(kanban): guard native review respawns during cooldown

---------

Co-authored-by: SoLo <solo@SoLoBot>
Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): restore native GitHub PR ingest

* fix(kanban): restore GitHub PR lifecycle safeguards

---------

Co-authored-by: SoLo <solo@SoLoBot>
* feat(kanban): enforce native review lifecycle

* fix(kanban): authorize review changes from active review runs

---------

Co-authored-by: SoLo <solo@SoLoBot>
* feat(kanban): enforce native review lifecycle

* fix(kanban): authorize review changes from active review runs

* ci: scope contributor checks to the PR base

---------

Co-authored-by: SoLo <solo@SoLoBot>
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/tui Terminal UI (ui-tui/ + tui_gateway/) area/config Config system, migrations, profiles area/profiles Multi-profile isolation, HERMES_HOME scoping P3 Low — cosmetic, nice to have needs-decision Awaiting maintainer decision before any implementation sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Aug 2, 2026

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preserving several local fixes and adding focused tests. Two changes need resolution before the bundle is reviewable.

Problems

  • agent/auxiliary_client.py:605-611 on current main intentionally skips kimi-coding for automatic vision routing; commit ff687c019e documents that the Coding Plan endpoint lacks image input and the fallback avoids 404s. This PR removes that safeguard while its revised test mocks vision support rather than exercising the actual transport.
  • agent/prompt_builder.py:2020 adds root AGENTS.md inheritance for named profiles. AGENTS.md:147-153 explicitly defines profiles as independent islands and identifies --clone as the supported copy-at-creation mechanism.

Suggested changes

  • Retain the Kimi auto-routing fallback unless an end-to-end Coding Plan image request verifies the new behavior.
  • Remove or separately discuss the profile-policy inheritance change.
  • Split the unrelated agent, OAuth, Kanban, TUI, CI, and test-runner changes into focused PRs with current-main repro and verification details.

Automated hermes-sweeper review.

Comment thread agent/auxiliary_client.py
# describe as having no image_in capability. Vision lives on the separate
# Kimi Platform (api.moonshot.ai, OpenAI-wire, pay-as-you-go). See #17076.
# NOTE: kimi-coding is intentionally NOT listed here. Kimi K3 on
# api.kimi.com/coding/v1 accepts OpenAI-style image_url content and models.dev

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current main intentionally keeps kimi-coding in _PROVIDERS_WITHOUT_VISION because the Coding Plan transport lacks image input; ff687c019e added the fallback after real 404s. Please retain that guard unless an end-to-end request against this exact transport proves image support.

Comment thread agent/prompt_builder.py
@@ -2013,6 +2020,49 @@ def load_soul_md(context_length: Optional[int] = None) -> Optional[str]:
return None

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces live root-to-named-profile policy inheritance. AGENTS.md:147-153 explicitly defines profiles as independent islands and points to --clone for copy-at-creation; please remove this change unless maintainers approve a deliberate change to that isolation contract.

@teknium1 teknium1 added sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state sweeper:risk-caching Sweeper risk: may break/degrade prompt caching or cache-key stability (invariant) sweeper:blast-broad Sweeper blast radius: broad — a core path most sessions hit labels Aug 2, 2026
solovision24 and others added 4 commits August 2, 2026 12:53
* fix(kanban): replay native review convergence on current base

* fix(kanban): restore same-card review remediation lifecycle

* fix(kanban): replay webhook review convergence on approved base

---------

Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): finalize claimed webhook review runs

* fix(kanban): correct native review handoff comment

---------

Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): hard-gate changes-required review completion

* fix(kanban): harden review remediation gates

* fix(kanban): bind review approval to immutable head

* fix(kanban): expose ready review remediation handoff

* fix(kanban): authorize remediation dependency exception

* fix(kanban): secure remediation handoff identity

* fix(kanban): harden remediation key contract

* fix(kanban): reject pre-seeded remediation keys

---------

Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): repair same-card review branch base

* fix(kanban): ignore archived prior review remediation keys

---------

Co-authored-by: SoLo <solo@SoLoBot>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles area/profiles Multi-profile isolation, HERMES_HOME scoping comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/tui Terminal UI (ui-tui/ + tui_gateway/) needs-decision Awaiting maintainer decision before any implementation P3 Low — cosmetic, nice to have sweeper:blast-broad Sweeper blast radius: broad — a core path most sessions hit sweeper:risk-caching Sweeper risk: may break/degrade prompt caching or cache-key stability (invariant) sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants