Dev/hermes upgrade t 16bbffad - #76853
Conversation
…026.7.20 upgrade - agent/conversation_loop.py: prioritise structured reasoning fields over inline-think content for tool_progress_callback relay - ui-tui appLayout.tsx: drop stale inputHeight box sizing (auto-size from rendered content instead) - ui-tui textInput.tsx: cancel pending fast-echo parent update on submit
Merged after independent verification: 54 focused lifecycle/tool/core tests passed, compileall and git diff --check passed, and the PR is limited to the upstream-compatible Hermes baseline.
* fix(kanban): allow requeued review workers past PR guard * fix(kanban): preserve review routing after crash requeue * fix(kanban): preserve native review lane on crash * fix(kanban): apply retry guards to native reviews * fix(kanban): guard native review respawns during cooldown --------- Co-authored-by: SoLo <solo@SoLoBot>
Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): restore native GitHub PR ingest * fix(kanban): restore GitHub PR lifecycle safeguards --------- Co-authored-by: SoLo <solo@SoLoBot>
* feat(kanban): enforce native review lifecycle * fix(kanban): authorize review changes from active review runs --------- Co-authored-by: SoLo <solo@SoLoBot>
* feat(kanban): enforce native review lifecycle * fix(kanban): authorize review changes from active review runs * ci: scope contributor checks to the PR base --------- Co-authored-by: SoLo <solo@SoLoBot>
teknium1
left a comment
There was a problem hiding this comment.
Thanks for preserving several local fixes and adding focused tests. Two changes need resolution before the bundle is reviewable.
Problems
agent/auxiliary_client.py:605-611on current main intentionally skipskimi-codingfor automatic vision routing; commitff687c019edocuments that the Coding Plan endpoint lacks image input and the fallback avoids 404s. This PR removes that safeguard while its revised test mocks vision support rather than exercising the actual transport.agent/prompt_builder.py:2020adds rootAGENTS.mdinheritance for named profiles.AGENTS.md:147-153explicitly defines profiles as independent islands and identifies--cloneas the supported copy-at-creation mechanism.
Suggested changes
- Retain the Kimi auto-routing fallback unless an end-to-end Coding Plan image request verifies the new behavior.
- Remove or separately discuss the profile-policy inheritance change.
- Split the unrelated agent, OAuth, Kanban, TUI, CI, and test-runner changes into focused PRs with current-main repro and verification details.
Automated hermes-sweeper review.
| # describe as having no image_in capability. Vision lives on the separate | ||
| # Kimi Platform (api.moonshot.ai, OpenAI-wire, pay-as-you-go). See #17076. | ||
| # NOTE: kimi-coding is intentionally NOT listed here. Kimi K3 on | ||
| # api.kimi.com/coding/v1 accepts OpenAI-style image_url content and models.dev |
There was a problem hiding this comment.
Current main intentionally keeps kimi-coding in _PROVIDERS_WITHOUT_VISION because the Coding Plan transport lacks image input; ff687c019e added the fallback after real 404s. Please retain that guard unless an end-to-end request against this exact transport proves image support.
| @@ -2013,6 +2020,49 @@ def load_soul_md(context_length: Optional[int] = None) -> Optional[str]: | |||
| return None | |||
There was a problem hiding this comment.
This introduces live root-to-named-profile policy inheritance. AGENTS.md:147-153 explicitly defines profiles as independent islands and points to --clone for copy-at-creation; please remove this change unless maintainers approve a deliberate change to that isolation contract.
* fix(kanban): replay native review convergence on current base * fix(kanban): restore same-card review remediation lifecycle * fix(kanban): replay webhook review convergence on approved base --------- Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): finalize claimed webhook review runs * fix(kanban): correct native review handoff comment --------- Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): hard-gate changes-required review completion * fix(kanban): harden review remediation gates * fix(kanban): bind review approval to immutable head * fix(kanban): expose ready review remediation handoff * fix(kanban): authorize remediation dependency exception * fix(kanban): secure remediation handoff identity * fix(kanban): harden remediation key contract * fix(kanban): reject pre-seeded remediation keys --------- Co-authored-by: SoLo <solo@SoLoBot>
* fix(kanban): repair same-card review branch base * fix(kanban): ignore archived prior review remediation keys --------- Co-authored-by: SoLo <solo@SoLoBot>
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs