fix(buzz): subscribe to newly joined channels - #76823
Conversation
Related to #74823 and #76156. This is the narrow event-driven join-subscription repair; #74823 expands startup discovery and #76156 adds broader membership reconciliation and addressing behavior. The overlap is real, but the scopes are not identical; please choose or consolidate the intended membership policy. |
|
Thanks for the narrow Buzz delivery repair. The current-main premise is verified: Commit Automated hermes-sweeper review. |
|
The intended scope of #76823 is deliberately narrow: preserve the existing startup discovery and addressing policies, and only repair live subscription when an automatic-mode agent receives a channel membership-add event. It does not attempt removal reconciliation, polling fallback, or addressing-policy changes. If maintainers prefer #74823’s broader startup membership policy, I’m happy for this PR to be considered superseded once that path lands.
Brice
--
"Ideas are everything. Charge accordingly."
Josh Bryer
… Le 2 août 2026 à 16:29, Siddharth Balyan ***@***.***> a écrit :
alt-glitch
left a comment
(NousResearch/hermes-agent#76823)
<#76823 (comment)>
This was generated by AI during triage.
Related to #74823 <#74823> and #76156 <#76156>. This is the narrow event-driven join-subscription repair; #74823 <#74823> expands startup discovery and #76156 <#76156> adds broader membership reconciliation and addressing behavior. The overlap is real, but the scopes are not identical; please choose or consolidate the intended membership policy.
—
Reply to this email directly, view it on GitHub <#76823?email_source=notifications&email_token=ABZC2MSJ3NAXTPHDIAN6IA35H5F3NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVHA2TGMJUGA2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5158531404>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZC2MXNUHW3ZRCTYCENK335H5F3NAVCNFSNUABGKJSXA33TNF2G64TZHMYTAMRUGU2TIMRWG45US43TOVSTWNJQGQZDQMBRGI4DTILWAI>.
You are receiving this because you authored the thread.
|
What changed
kind:44100membership events.BUZZ_CHANNELSlist authoritative; automatic discovery only applies when that list is empty.Root cause
_handle_membership_event()called_discover_dms()and subscribed anything it added. That helper intentionally excludes real community channels to avoid misclassifying them as mention-free DMs, so a channel joined after gateway startup never entered_channel_state. The gateway only saw it after a restart rebuilt the initial channel list.User impact
With automatic Buzz channel discovery enabled, adding the Hermes identity to a public, private, or ephemeral channel now makes the running gateway listen immediately. Users no longer need to restart the gateway after each channel addition.
Validation
scripts/run_tests.sh tests/gateway/test_buzz_adapter.py tests/gateway/test_buzz_websocket.py -q(30 passed).venv/bin/ruff check plugins/platforms/buzz/adapter.py tests/gateway/test_buzz_websocket.pygit diff --check