Skip to content

feat(kanban): enforce native review handoff evidence (#10) - #76790

Open
solovision24 wants to merge 1 commit into
NousResearch:mainfrom
solovision24:review-base-origin-main
Open

feat(kanban): enforce native review handoff evidence (#10)#76790
solovision24 wants to merge 1 commit into
NousResearch:mainfrom
solovision24:review-base-origin-main

Conversation

@solovision24

Copy link
Copy Markdown
  • feat(kanban): route implementation handoffs through review

  • fix(kanban): allow requeued review workers past PR guard (Add logging for first 100 chars of the tool call args json / tool response #9)

  • fix(kanban): allow requeued review workers past PR guard

  • fix(kanban): preserve review routing after crash requeue

  • fix(kanban): preserve native review lane on crash

  • fix(kanban): apply retry guards to native reviews

  • fix(kanban): guard native review respawns during cooldown


  • feat(kanban): enforce native review handoff evidence

  • fix(kanban): make native review handoff canonical


What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

* feat(kanban): route implementation handoffs through review

* fix(kanban): allow requeued review workers past PR guard (#9)

* fix(kanban): allow requeued review workers past PR guard

* fix(kanban): preserve review routing after crash requeue

* fix(kanban): preserve native review lane on crash

* fix(kanban): apply retry guards to native reviews

* fix(kanban): guard native review respawns during cooldown

---------

Co-authored-by: SoLo <solo@SoLoBot>

* feat(kanban): enforce native review handoff evidence

* fix(kanban): make native review handoff canonical

---------

Co-authored-by: SoLo <solo@SoLoBot>

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending the existing review lane with a structured handoff and immutable metadata validation. Current main still uses the review-required block convention (agent/prompt_builder.py:246-253), so this is not redundant.

Problems

  • The new preservation logic only covers detect_crashed_workers (hermes_cli/kanban_db.py:7815-7840). Other running-task recovery paths in this PR head still set status='ready': TTL reclaim (hermes_cli/kanban_db.py:4734), max-runtime timeout (:7433), and stale-worker recovery (:7558). Those cards then use ordinary ready dispatch, whereas sdlc-review is force-loaded only in review dispatch (:8827-8870). A timed-out, stale, or failed-to-spawn reviewer can therefore lose its review-lane contract.

Suggested changes

  • Route every running-to-retry transition through one source-lane helper and add coverage for TTL and timeout/stale requeues of review cards.

Automated hermes-sweeper review.

Comment thread hermes_cli/kanban_db.py
requeued_review = bool(
latest_claim and latest_claim["source_status"] == "review"
)
requeue_status = "review" if requeued_review else "ready"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This preserves the review lane only for detected crashes. TTL reclaim, max-runtime timeout, stale-worker recovery, and review-spawn failure still transition a claimed review task to ready, which routes it through ordinary dispatch rather than the sdlc-review path. Please centralize this source-lane decision and cover those retry paths.

@alt-glitch alt-glitch added type/feature New feature or request comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/tools Tool registry, model_tools, toolsets P3 Low — cosmetic, nice to have labels Aug 2, 2026
@teknium1 teknium1 added sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/tools Tool registry, model_tools, toolsets P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants