feat(kanban): enforce native review handoff evidence (#10) - #76790
Open
solovision24 wants to merge 1 commit into
Open
feat(kanban): enforce native review handoff evidence (#10)#76790solovision24 wants to merge 1 commit into
solovision24 wants to merge 1 commit into
Conversation
* feat(kanban): route implementation handoffs through review * fix(kanban): allow requeued review workers past PR guard (#9) * fix(kanban): allow requeued review workers past PR guard * fix(kanban): preserve review routing after crash requeue * fix(kanban): preserve native review lane on crash * fix(kanban): apply retry guards to native reviews * fix(kanban): guard native review respawns during cooldown --------- Co-authored-by: SoLo <solo@SoLoBot> * feat(kanban): enforce native review handoff evidence * fix(kanban): make native review handoff canonical --------- Co-authored-by: SoLo <solo@SoLoBot>
teknium1
reviewed
Aug 2, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for extending the existing review lane with a structured handoff and immutable metadata validation. Current main still uses the review-required block convention (agent/prompt_builder.py:246-253), so this is not redundant.
Problems
- The new preservation logic only covers
detect_crashed_workers(hermes_cli/kanban_db.py:7815-7840). Other running-task recovery paths in this PR head still setstatus='ready': TTL reclaim (hermes_cli/kanban_db.py:4734), max-runtime timeout (:7433), and stale-worker recovery (:7558). Those cards then use ordinary ready dispatch, whereassdlc-reviewis force-loaded only in review dispatch (:8827-8870). A timed-out, stale, or failed-to-spawn reviewer can therefore lose its review-lane contract.
Suggested changes
- Route every running-to-retry transition through one source-lane helper and add coverage for TTL and timeout/stale requeues of review cards.
Automated hermes-sweeper review.
| requeued_review = bool( | ||
| latest_claim and latest_claim["source_status"] == "review" | ||
| ) | ||
| requeue_status = "review" if requeued_review else "ready" |
Contributor
There was a problem hiding this comment.
This preserves the review lane only for detected crashes. TTL reclaim, max-runtime timeout, stale-worker recovery, and review-spawn failure still transition a claimed review task to ready, which routes it through ordinary dispatch rather than the sdlc-review path. Please centralize this source-lane decision and cover those retry paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(kanban): route implementation handoffs through review
fix(kanban): allow requeued review workers past PR guard (Add logging for first 100 chars of the tool call args json / tool response #9)
fix(kanban): allow requeued review workers past PR guard
fix(kanban): preserve review routing after crash requeue
fix(kanban): preserve native review lane on crash
fix(kanban): apply retry guards to native reviews
fix(kanban): guard native review respawns during cooldown
feat(kanban): enforce native review handoff evidence
fix(kanban): make native review handoff canonical
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs