docs: shrink AGENTS.md below prompt cap - #7678
fortunexbt wants to merge 2 commits into
Conversation
Trim repo guidance so AGENTS.md stays under Hermes context-file truncation limit while keeping the critical developer instructions intact.
alt-glitch
added
type/docs
teknium1
left a comment
teknium1
left a comment
There was a problem hiding this comment.
Thanks for addressing the context-file size problem. The premise remains current: AGENTS.md is 71,537 bytes while agent/prompt_builder.py:1171-1219 retains a 20,000-character default cap and truncates oversized files at agent/prompt_builder.py:1779-1816.
Problems
AGENTS.md:185in this PR restores a manualmodel_tools.pyimport step, but current tool discovery imports top-level registrations automatically (tools/registry.py:58-75; current guidance atAGENTS.md:522-547).AGENTS.md:225says every config addition requires a version bump; current guidance limits bumps to active migrations (AGENTS.md:584-590).AGENTS.md:338restoresMESSAGING_CWDas canonical, while current guidance usesterminal.cwdand deprecates that environment variable (AGENTS.md:636-642).
Suggested changes
- Rebuild the concise version from current
main, preserving current facts while reducing duplication. - Consider the linked open alternative, #53996, before selecting an in-place trim versus an extended-reference split.
This is an automated hermes-sweeper review.
| New tools require changes in 3 places: | ||
|
|
||
| 1. Create `tools/your_tool.py` | ||
| 2. Import it in `model_tools.py` inside `_discover_tools()` |
There was a problem hiding this comment.
This manual model_tools.py import step is obsolete. Current tools/registry.py:58-75 auto-imports top-level registry.register() modules; current guidance correctly requires only creating the tool file and adding it to a toolset (AGENTS.md:522-547).
| 2. Bump `_config_version` (currently 5) to trigger migration for existing users | ||
|
|
||
| 1. Add the key to `DEFAULT_CONFIG` in `hermes_cli/config.py` | ||
| 2. Bump `_config_version` (currently 5) so existing installs migrate |
There was a problem hiding this comment.
Please not restore the unconditional version-bump rule. Current guidance says _config_version changes are only for active migrations; normal deep-merged config additions do not need one (AGENTS.md:584-590).
|
|
||
| ### Background Process Notifications (Gateway) | ||
| - CLI: current directory (`os.getcwd()`) | ||
| - Messaging: `MESSAGING_CWD` env var, defaulting to the user's home directory |
There was a problem hiding this comment.
MESSAGING_CWD is no longer the documented configuration mechanism. Current main uses terminal.cwd in config.yaml and treats both MESSAGING_CWD and .env-set TERMINAL_CWD as deprecated (AGENTS.md:636-642).
teknium1
added
the
sweeper:blast-broad
3 participants
Summary
Validation